Solis fixes (working on v1) and automatic battery size #3189

springfall2008 · 2026-01-05T20:25:44Z

No description provided.

Solis control fixes

Reformatted the description of the 'soc_max' parameter for better readability.

Copilot

Pull request overview

This PR adds automatic battery size detection for Solis inverters and includes various fixes for Solis V1 firmware support. The main enhancement allows Predbat to estimate battery capacity from historical charging data when soc_max is not configured, while maintaining manual configuration as the recommended approach.

Key changes:

Automatic battery size detection: New find_battery_size() method in inverter.py analyzes historical SoC and power data to estimate battery capacity
Solis V1 fixes: Enhanced charge/discharge slot detection logic to properly check enable flags and differentiate between in-slot and out-of-slot storage modes
Bug fixes: Corrected rate application logic in Axle integration, fixed component restart behavior, and improved Solis entity state handling

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 20 comments.

Show a summary per file

File	Description
docs/components.md	Updated Solis documentation to explain automatic vs manual battery size configuration
docs/apps-yaml.md	Expanded battery size configuration guidance with automatic detection details
apps/predbat/unit_test.py	Registered new battery size detection tests in test suite
apps/predbat/tests/test_find_battery_size.py	Added comprehensive test suite for battery size detection algorithm
apps/predbat/tests/test_solis.py	Added tests for fetch_entity_data, fixed switch state assertions to use "on"/"off"
apps/predbat/tests/test_execute.py	Added stub find_battery_size method to mock inverter for test compatibility
apps/predbat/solis.py	Major fixes: fetch_entity_data for V1 control, enable flag checking, storage mode logic, entity publishing fixes, battery_power_invert config
apps/predbat/predbat.py	Version bump to v8.31.10
apps/predbat/octopus.py	Fixed end_minutes calculation for saving sessions extending beyond forecast
apps/predbat/inverter.py	Implemented automatic battery size detection from historical charge data, fallback to 8kWh default
apps/predbat/components.py	Fixed component restart to call both initialization phases
apps/predbat/component_base.py	Moved first flag clearing outside api_started check for proper startup handling
apps/predbat/axle.py	Simplified rate addition logic using dict.get() and fixed end_minutes calculation

Copilot · 2026-01-05T20:31:50Z

apps/predbat/solis.py

        # Battery and inverter entities
        self.set_arg("soc_percent", [f"sensor.predbat_solis_{device}_battery_soc" for device in devices])
        self.set_arg("battery_power", [f"sensor.predbat_solis_{device}_battery_power" for device in devices])
+        self.set_arg("battery_power_invert", [f"True" for device in devices])


The battery_power_invert is set to the string "True" instead of the boolean True. This should be [True for device in devices] to ensure proper boolean handling in the codebase. String values may not work correctly with boolean comparisons elsewhere in the code.

Suggested change

self.set_arg("battery_power_invert", [f"True" for device in devices])

self.set_arg("battery_power_invert", [True for device in devices])

Copilot · 2026-01-05T20:31:51Z

apps/predbat/solis.py

+        # Frequent polling (every minute)
+        if first or (seconds % 60 == 0):
            for sn in self.inverter_sn:
                success =  await self.fetch_inverter_details(sn) # Get inverter details for all inverters


Extra space before the assignment operator. Should be success = await not success = await (two spaces).

apps/predbat/solis.py

Copilot · 2026-01-05T20:31:51Z

apps/predbat/solis.py


+    async def fetch_entity_data(self, sn):
+        """
+        This use to fetch HA data for the charge/discharge windows directly frome Home Assistant using get_state_wrapper()


Typo in docstring: "use to fetch" should be "used to fetch"

Suggested change

This use to fetch HA data for the charge/discharge windows directly frome Home Assistant using get_state_wrapper()

This is used to fetch HA data for the charge/discharge windows directly from Home Assistant using get_state_wrapper()

apps/predbat/inverter.py

Copilot · 2026-01-05T20:31:54Z

apps/predbat/tests/test_find_battery_size.py

+        timestamp_str = timestamp.strftime("%Y-%m-%dT%H:%M:%S%z")
+
+        hour = timestamp.hour
+        minute_of_hour = timestamp.minute


Variable minute_of_hour is not used.

Suggested change

minute_of_hour = timestamp.minute

Copilot · 2026-01-05T20:31:55Z

apps/predbat/axle.py

-                            base.rate_export[minute] += pence_per_kwh
-                            rate_replicate[minute] = "saving"
+                        base.rate_export[minute] = base.rate_export.get(minute, 0) + pence_per_kwh
+                        rate_replicate[minute] = "saving"


This expression mutates a default value.

Copilot · 2026-01-05T20:31:55Z

apps/predbat/axle.py

-                            rate_replicate[minute] = "saving"
+                        base.rate_import[minute] = base.rate_import.get(minute, 0) + pence_per_kwh
+                        base.load_scaling_dynamic[minute] = base.load_scaling_saving
+                        rate_replicate[minute] = "saving"


This expression mutates a default value.

Copilot · 2026-01-05T20:31:55Z

apps/predbat/solis.py

+                        pass
+                if power_state is not None:
+                    try:
+                        max_current_amps = self.max_charge_current.get(sn, 100) if direction == 'charge' else self.max_discharge_current.get(sn, 100)
+                        value = max(0, min(int(float(power_state) / self.nominal_voltage), max_current_amps))
+                        self.charge_discharge_time_windows[sn][slot][f"{direction}_current"] = value
+                    except (ValueError, TypeError):
+                        pass


'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

pass

if power_state is not None:

try:

max_current_amps = self.max_charge_current.get(sn, 100) if direction == 'charge' else self.max_discharge_current.get(sn, 100)

value = max(0, min(int(float(power_state) / self.nominal_voltage), max_current_amps))

self.charge_discharge_time_windows[sn][slot][f"{direction}_current"] = value

except (ValueError, TypeError):

pass

self.log("Solis: Ignoring invalid SOC state '{}' for inverter {} slot {} direction {}".format(soc_state, sn, slot, direction))

if power_state is not None:

try:

max_current_amps = self.max_charge_current.get(sn, 100) if direction == 'charge' else self.max_discharge_current.get(sn, 100)

value = max(0, min(int(float(power_state) / self.nominal_voltage), max_current_amps))

self.charge_discharge_time_windows[sn][slot][f"{direction}_current"] = value

except (ValueError, TypeError):

self.log("Solis: Ignoring invalid power state '{}' for inverter {} slot {} direction {}".format(power_state, sn, slot, direction))

Copilot · 2026-01-05T20:31:55Z

apps/predbat/solis.py

+                        max_current_amps = self.max_charge_current.get(sn, 100) if direction == 'charge' else self.max_discharge_current.get(sn, 100)
+                        value = max(0, min(int(float(power_state) / self.nominal_voltage), max_current_amps))
+                        self.charge_discharge_time_windows[sn][slot][f"{direction}_current"] = value
+                    except (ValueError, TypeError):


'except' clause does nothing but pass and there is no explanatory comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

springfall2008 added 3 commits January 5, 2026 19:42

Battery size automatic finding

594d20b

Solis control fixes

Solis fixes for inverter size

b3feffa

Fixes

6ce0241

Copilot AI review requested due to automatic review settings January 5, 2026 20:25

Copilot started reviewing on behalf of springfall2008 January 5, 2026 20:26 View session

pre-commit-ci-lite bot and others added 2 commits January 5, 2026 20:27

[pre-commit.ci lite] apply automatic fixes

29b3125

Improve formatting of 'soc_max' parameter description

45dfbcf

Reformatted the description of the 'soc_max' parameter for better readability.

Copilot AI reviewed Jan 5, 2026

View reviewed changes

springfall2008 and others added 2 commits January 5, 2026 20:33

Update apps/predbat/solis.py

1b3748f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update apps/predbat/inverter.py

a026b31

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

springfall2008 merged commit f7f3cc2 into main Jan 5, 2026
1 check passed

springfall2008 deleted the battery_size branch January 5, 2026 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Solis fixes (working on v1) and automatic battery size #3189

Solis fixes (working on v1) and automatic battery size #3189

Uh oh!

springfall2008 commented Jan 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Copilot AI Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	self.set_arg("battery_power_invert", [f"True" for device in devices])
	self.set_arg("battery_power_invert", [True for device in devices])

	This use to fetch HA data for the charge/discharge windows directly frome Home Assistant using get_state_wrapper()
	This is used to fetch HA data for the charge/discharge windows directly from Home Assistant using get_state_wrapper()

Uh oh!

Solis fixes (working on v1) and automatic battery size #3189

Solis fixes (working on v1) and automatic battery size #3189

Uh oh!

Conversation

springfall2008 commented Jan 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants