Skip to content

mapping numbers to integers in encode to prevent float division issues #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4kimov merged 1 commit into from
Apr 19, 2025
Merged

mapping numbers to integers in encode to prevent float division issues #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sqids.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def initialize(options = {})
def encode(numbers)
return '' if numbers.empty?

in_range_numbers = numbers.select { |n| n >= 0 && n <= Sqids.max_value }
in_range_numbers = numbers.map(&:to_i).select { |n| n >= 0 && n <= Sqids.max_value }
unless in_range_numbers.length == numbers.length
raise ArgumentError,
"Encoding supports numbers between 0 and #{Sqids.max_value}"
Expand Down
8 changes: 8 additions & 0 deletions spec/encoding_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@
expect(sqids.encode([])).to eq('')
end

it 'encoding with float' do
sqids = Sqids.new
float = 3.14159265
encoded_float = sqids.encode([float])
encoded_int = sqids.encode([float.to_i])
expect(encoded_float).to eq(encoded_int)
end

it 'decoding empty string' do
sqids = Sqids.new
expect(sqids.decode('')).to eq([])
Expand Down
Loading