No "double creation" of Scene objects for products with Kind.IMAGE #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
whewww ... coveralls is really cutting it close ... need to add a unit test for that one-liner 😇 |
RudiLauster
force-pushed
the
issue456_dataset_two_scene_objects
branch
from
c4e5104 to
cccd9a8
Compare
Collaborator
Author
|
Hello Andrea @ameraner , so, just adding Kind.IMAGE to the list of accepted "kinds" as still believed here #456 (comment) wasn't the entire solution. Would have been too easy, anyway. I analysed the issue in more detail and did several tryouts and so far came to this conclusion: #456 (comment) Guess we need to talk 📞😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the "double scene creation" issue for products with "Kind.IMAGE" (like FCI)
Opening a dataset initialises two Scene objects with two respective load calls