fix: only filter displayed recent models from provider sections #6190
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Models in positions 6-10 of the recent list were being filtered out from provider sections even though they weren't displayed in the Recent section (which only shows top 5). This caused models like github-copilot/claude-sonnet-4.5 to disappear from the provider sections if they were in the recent list but beyond position 5. Changed the filter to use recentList (displayed models) instead of recents (all models) to fix this issue.
Collaborator
|
/review |
Contributor
|
lgtm |
Collaborator
|
this seems to introduce a regression in recents list in my testing, any model I try just replaces top model in recents list instead of the previous behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Models are not displayed anywhere in the model dialog if they are in the recent list but beyond position 5.
Changed the filter to use recentList (displayed recent models) instead of recents (all recent models) to fix this issue.