fix(superset): Add patch to pin the sax package to 1.2.4 #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently my version of git dropped the last character of both commit IDs. This might be a thing to investigate down the line.
Techassi
moved this from Development: In Progress
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the
saxpackage of Superset (frontend) 4.1.x to 1.2.4 in order to fix the following issue encountered since the last few scheduled CI runs:This error is very similar to errors fixed in #1315 and #1316. This is a known weakness/bug in npm.
Local test builds of Superset 4.1.2 and 4.1.4 succeeded with this fix, and a test build in CI also succeeded: https://github.com/stackabletech/docker-images/actions/runs/20274450552