Skip to content

Test/add tests ingest #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cblanquera merged 4 commits into from
Dec 2, 2024
Merged

Test/add tests ingest #3

cblanquera merged 4 commits into from
Dec 2, 2024

Conversation

@amerah-abdul
Copy link
Contributor

@amerah-abdul amerah-abdul commented Nov 29, 2024 •
edited
Loading

What is this PR for?

  • Just updating content and/or documentation
  • This fixes issue #_____
  • Spot fix (no issue #)
  • Merging WIP feature #_____
  • Merging done feature #_____
  • This is a merge from a version branch
  • Adding/Updating tests
  • This is a conflict resolution
  • This is a branch cleanup
  • Other: ________________

I verify that...

  • I have logged my time in the commits
  • I have logged my time in this PR
  • I have tagged all the relevant issues
  • I am using VS Code for type checks and linting, or
  • I have ran npm run test with no errors
  • I have manually checked that this bug or feature is working

cblanquera
cblanquera approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@cblanquera cblanquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. No issues

packages/ingest/tests/Response.test.ts
Copy link
Member

@cblanquera cblanquera Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Body test is a good test. thanks!

packages/ingest/tests/helpers.test.ts
Copy link
Member

@cblanquera cblanquera Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the stream tests!

@cblanquera cblanquera merged commit c6e3379 into stackpress:main Dec 2, 2024
1 check passed
@amerah-abdul amerah-abdul changed the title Feature/new added tests tests/add tests ingests Dec 10, 2024
@amerah-abdul amerah-abdul changed the title tests/add tests ingests Test/add tests ingests Dec 10, 2024
@amerah-abdul amerah-abdul changed the title Test/add tests ingests Test/add tests ingest Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblanquera cblanquera cblanquera approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amerah-abdul @cblanquera