-
Notifications
You must be signed in to change notification settings - Fork 8
feature/add supabase connection with neon connection cleanup (forgot some stuff) 3d #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…alect ignores this clause).
mysql2-test-coverage
create a test coverage in inquire:pg
unit test in sqlite3
feature/add neon connection 3d
cblanquera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review feedback.
examples/with-supabase/.env
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super bad.
Do not include private keys and connections to code repository. It is very hard to clean this kind of commit. This is a mortal sin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used git filter-repo to remove the file from the commit history containing the private keys. Should I proceed with this, or should I find another way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this, it's a txt copy of the gitignore file that I committed by mistake on my last pr, which I'm trying to remove now.
What is this PR for?
I verify that...
npm run testwith no errors