-
Notifications
You must be signed in to change notification settings - Fork 77
Rated+ #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasonyess
wants to merge
20
commits into
stadust:master
Choose a base branch
from
jasonyess:rated-plus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rated+ #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a
ratedbool column and arated_positioninteger column to thedemonstable (representing the demon's position on the list with only rated demons)for stats viewers,
unrated_rankandunrated_scorecolumns are added for everyrankandscorecolumn that currently existsthe majority of struct and query changes are just refactoring to account for these new columns
for passing list context information in the backend i just made a
Listenum so i dont need to pass around anis_rated_listbool of some sort everywherein the frontend it's a
data-listattribute in the html tag for css and awindow.active_listfor the jsfor the different list pages, the uris are now
/<list>/...as opposed to always being/demonlist/...(so rated+ pages would be/ratedplus/...)world map in stats viewers are now in the same context as the rest of the document as opposed to being in its own object context, so use of differently colored heatmaps is possible just by referencing different stylesheets in the document head
also russian translations are still missing but ill commit those later
if theres anything that needs the most testing it's the movement logs and time machine 🥺
this general implementation already went through zoe, she also asks that this doesnt get merged or deployed until shes done with her side of the rated+ work
resolves #279
License Acceptance
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.