Skip to content

Conversation

@jasonyess
Copy link
Contributor

suggested in hq, renamed profile to settings and list integration to profile

also hid some settings fields (youtube channel, display name, and permissions) behind elevated perms (aka perm bits > 0)
initial suggestion was behind list helper but that permission is in a demonlist crate, which presumably shouldnt be dependencies of user crates

didnt add any additional logic to the PATCH /auth/me/ since the goal was (presumably) just to reduce confusion surrounding these fields; theres no harm in allowing them to be modified via the api

License Acceptance

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.14%. Comparing base (fb99bc7) to head (4d9fbc5).

Files with missing lines Patch % Lines
pointercrate-user-pages/src/account/settings.rs 0.00% 17 Missing ⚠️
pointercrate-core/src/permission.rs 0.00% 3 Missing ⚠️
...ointercrate-demonlist-pages/src/account/profile.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   36.16%   36.14%   -0.02%     
==========================================
  Files         121      121              
  Lines        5837     5840       +3     
==========================================
  Hits         2111     2111              
- Misses       3726     3729       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant