feat: generate symbols ordering #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the TradingView symbols generation script to implement a more sophisticated ordering system for selecting the optimal trading pair for each symbol. The script now prioritizes symbols first by quote currency (USD > USDC > USDT) and then by data provider (Coinbase > Binance > Crypto.com > Kraken > OKX > CRYPTOCAP), resulting in many symbols switching from USDT pairs to USD pairs and changing providers accordingly.
Changes:
- Refactored symbol generation script by extracting utilities into a separate module
- Implemented dual-priority ordering: currency preference first, then provider preference
- Updated trading symbols data with new preferred pairs and providers based on the new ordering logic
- Minor UI improvements to loading overlay opacity and card hover states
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/generate-tradingview-symbols/utils.ts | New file containing extracted schemas, types, and ordering utilities for the symbol generation script |
| scripts/generate-tradingview-symbols/index.ts | Refactored to use extracted utilities and implement new dual-priority ordering system (currency + provider) |
| src/assets/tradingview-symbols.json | Updated with regenerated symbol mappings reflecting new ordering priorities - many symbols changed from USDT to USD pairs and switched providers |
| package.json | Updated script path to point to the new index.ts location within the reorganized directory structure |
| src/components/modules/PositionDetails/Overview/Chart/index.tsx | Changed loading overlay background from semi-transparent to fully opaque |
| src/components/modules/Home/Positions/position-card.tsx | Added hover effect with subtle background color change for better UX |
| src/components/modules/Home/Positions/order-card.tsx | Added hover effect with subtle background color change for better UX |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Philippoes
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.