-
Notifications
You must be signed in to change notification settings - Fork 3
Update web3py to 7 #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update web3py to 7 #164
Conversation
# Conflicts: # pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the web3py library from version 6.15.1 to version 7.13.0, along with updating py-ecc from version 6.0.0 to 8.0.0. The changes include API compatibility updates and the removal of Proof of Authority (POA) network configurations.
- Removed POA-related configurations and middleware from network settings and execution client
- Updated API calls to match web3py v7 parameter naming conventions
- Added custom HTTP session management for better control over request handling
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates web3 dependency from 6.15.1 to 7.13.0 and py-ecc from ^6.0.0 to ^8.0.0 |
| sw_utils/networks.py | Removes IS_POA configuration field from all network configurations |
| sw_utils/execution.py | Removes POA middleware, updates imports, and adds custom session management |
| sw_utils/consensus.py | Updates API parameter names and implements custom HTTP session handling |
| sw_utils/event_scanner.py | Updates parameter names from camelCase to snake_case |
| sw_utils/http_session_manager.py | Adds new ExtendedHTTPSessionManager class for handling HTTP requests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* Add get_validators_by_statuses * Bump v0.10.3 * Fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (2)
sw_utils/networks.py:1
- Removal of the IS_POA attribute is a breaking change for any consumers referencing network configurations (e.g., conditional POA middleware injection). Consider retaining it (possibly deprecated) or documenting the removal clearly with a migration note.
from dataclasses import dataclass
sw_utils/execution.py:1
- The removal of is_poa and change of use_cache default from True to False are silent breaking changes; existing callers may rely on automatic POA middleware injection or previous caching behavior. Consider adding backward-compatible parameters with deprecation warnings or clearly documenting migration steps (and, if POA support is still needed, exposing an alternative hook).
import logging
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.