Change required rubocop version: ~> 1.81.7 to ~> 1.82.1 #778
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use standard gem in ruby 4.0, I want to make it possible to use rubocop 1.82.0 or higher, which supports ruby 4.0. Therefore, following past conventions, I have proposed upgrading the rubocop version here.
I referred to the following PR, as it seems to be where the previous change was implemented.
While
~> 1.82.0would have been sufficient, the latest rubocop version currently released is 1.82.1. Since previous version updates seem to have been based on setting the requirement to the latest version available at the time, I have set it to~> 1.82.1for this instance.FYI: It looks like there's another related PR:
It appeared that this Dependabot PR was causing CI to fail because new Style/ModuleMemberExistenceCheck cop was added in version 1.82.0, so I have included the necessary fix in this PR. Following past conventions, I simply disabled it this time.