chore: bump Ruby to 3.3, use symbols for ElementPatchMode #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismasan
reviewed
Jan 14, 2026
Collaborator
ismasan
left a comment
ismasan
left a comment
There was a problem hiding this comment.
This PR seems to be doing unrelated things:
- Increase the required Ruby version (why?)
- Replace the default options Hash with a Data struct, but it's not clear what for.
| only_if_missing: DEFAULT_ONLY_IF_MISSING | ||
| ) | ||
|
|
||
| def with(overrides) |
Collaborator
There was a problem hiding this comment.
Data objects already define a #with method for this.
Collaborator
There was a problem hiding this comment.
How do you plan to use this? Currently, the OPTION_DEFAULTS hash is accessed within the build_options method, so there's not much use in being able to create a copy of this Data struct with overrides. If there's no plan to use it for something specific I'm not sure we need it.
Contributor
Author
There was a problem hiding this comment.
What i wanted to do. is not worth. I benchmarked it, and we get very little gain.
I recycled this PR to have the bump only.
- Ruby 3.3+ required (3.2 EOL March 2026) - Add rubygems_mfa_required metadata - Use symbols instead of strings for ElementPatchMode constants
seuros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop rubies version that should never reach the stars.
Less object allocation ==> faster gem.