Merge 4.1.3 to main
#1851
Closed
Merge 4.1.3 to main
#1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…24 deposit transaction
…nt in Sep24 deposit transaction (#1844) ### Description - Fix the InternalException thrown from the `notify_onchain_fund_sent` in Sep24 deposit transaction ### Context - After submitting Sep24 deposit transaction from demo wallet, anchor platform keeps throwing exceptions. This is caused by the reference server calling the `notify_onchain_fund_sent` after the transaction is in `completed` status. ### Testing - `./gradlew test`
… no filtered events received
…sed (#1845) ### Description - Fix observer not updating `ap_payment_observer_latest_block_read` and `ap_payment_observer_latest_block_processed` ### Context - When switching from RPC `getTransaction` to `getEvent`, the events are filtered with the distribution account. When no payment is processed, the ledger count will not upate.
### Description - While we are deprecating the custody and no partners are using the feature, we may disable the tests. - Remove CodeQL since we have Cursor installed. ### Context - Stablizing the tests.
### Description - The Sep24 `DepositService` calls RPC right after submission of the Stellar transaction. Calling `notify_onchain_funds_sent` while the transaction is still in pending state may causes the reference server to enter strange state and kept retrying. - Remove the unnecessary RPC retries when we wait for transaction SUCCESS status. ### Context - Bug fix <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Waits for the sent Stellar transaction to succeed before notifying RPC and drops the previous flow-based retry logic. > > - **Backend (SEP-24 `DepositService`)**: > - Add `waitForValidTransaction` to poll `paymentClient.getTransaction` until `SUCCESS` (or fail), with optional timeout. > - Use confirmed `txHash` result post-send, then finalize via `notify_onchain_funds_sent`; remove immediate finalize after send. > - Remove `flow`/`retryWhen` RPC retry loop; simplify to single `rpcAction` call. > - Minor: add `withTimeout` and `GetTransactionResponse` imports; capture `txHash` outside retry block. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4976a73. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
4.1.3tomainContext