fix(windows): emit error callback when GetCharacteristic/GetDescripto… #60
+22
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r fails When GetCharacteristic or GetDescriptor fails (e.g., user cancels Windows BLE pairing dialog), the code was only logging the error but not calling the emit callback to notify JavaScript. This caused the Promise/callback to hang indefinitely. Fixed functions: - Read: now calls mEmit.Read() on GetCharacteristic failure - Write: now calls mEmit.Write() on GetCharacteristic failure - Notify: now calls mEmit.Notify() on GetCharacteristic failure - DiscoverDescriptors: now calls mEmit.DescriptorsDiscovered() on failure - ReadValue: now calls mEmit.ReadValue() on GetDescriptor failure - WriteValue: now calls mEmit.WriteValue() on GetDescriptor failure This ensures JavaScript always receives a callback (success or error), preventing hangs when BLE operations fail due to pairing issues. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r fails
When GetCharacteristic or GetDescriptor fails (e.g., user cancels Windows BLE pairing dialog), the code was only logging the error but not calling the emit callback to notify JavaScript. This caused the Promise/callback to hang indefinitely.
Fixed functions:
This ensures JavaScript always receives a callback (success or error), preventing hangs when BLE operations fail due to pairing issues.