Fix some params potential risk #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelodyFish
requested review from
DonFungible,
LeoHChen,
SoYoung210,
allenchuang and
samfairbairn
as code owners
|
Someone is attempting to deploy a commit to the Story Protocol Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default value to an empty string for the rpcUrl, apiKey and appId properties of StoryKitProvider.
Because:
In the StoryKitProvider component, we used to deal with
rpcUrl,apiKeyandappIdattributes. When users don't pass these attributes, their values will beundefined. This may lead to the need for additional undefined checks in the subsequent code, which increases the complexity of the code and the potential risk of errors.