fix(telemetry): prevent double counting of usage metrics #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent double counting
rajib76
requested a deployment
to
manual-approval
GitHub Actions
Waiting
rajib76
changed the title
Contributor
Author
|
I created a new pull request for this pull request# 1327 |
Contributor
|
@rajib76 could you update the code based on this reply: #1267 (comment) I can make the new PR too if preferred. |
7 tasks
poshinchen
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
poshinchen
had a problem deploying
to
manual-approval
GitHub Actions
Failure
poshinchen
had a problem deploying
to
manual-approval
GitHub Actions
Failure
poshinchen
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
dbschmigelski
requested changes
Dec 18, 2025
afarntrog
previously approved these changes
Dec 18, 2025
poshinchen
force-pushed
the
fix/telemetry-double-counting
branch
from
a06b5d8 to
adf38bf
Compare
poshinchen
requested a deployment
to
manual-approval
GitHub Actions
Waiting
poshinchen
force-pushed
the
fix/telemetry-double-counting
branch
from
adf38bf to
76a1577
Compare
poshinchen
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
dbschmigelski
approved these changes
Dec 18, 2025
afarntrog
approved these changes
Dec 18, 2025
|
Thank you very much @poshinchen for resolving this so quickly! Would love to connect with you on discord, pls share details if okay with it. This change will go in 1.21.0, right? If yes, when can we expect the package release. |
Contributor
|
Sorry I don't have discord account. The next release should be on next Tuesday / Wednesday. |
JackYPCOnline
pushed a commit
to CrysisDeu/sdk-python
that referenced
this pull request
Dec 19, 2025
…nts#1327) * fix(telemetry): remove duplicate accumulation of usage metrics to prevent double counting * add langfuse observation type to invoke_agent to prevent double counting --------- Co-authored-by: RAJIB DEB <rajibdeb@mac.lan> Co-authored-by: poshinchen <pschen@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for the below bug:
_[BUG] OpenTelemetry token/cost metrics double-counted in Langfuse due to duplicate reporting on parent and child spans #1267
Related Issues
#1267
Documentation PR
Type of Change
Bug fix
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.