bidi - async - remove cancelling call #1357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrayy
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pgrayy
commented
Dec 17, 2025
| Attributes: | ||
| _tasks: List of tasks in group. | ||
| _tasks: Set of tasks in group. |
Member
Author
There was a problem hiding this comment.
Switching to set to be consistent with asyncio.wait which puts done_tasks and pending_tasks into sets. This in turn helps to resolve a mypy error.
pgrayy
commented
Dec 17, 2025
| - The context re-raises Exceptions to the caller. | ||
| - The context re-raises CancelledErrors to the caller only if the context itself was cancelled. | ||
| """ | ||
| try: |
Member
Author
There was a problem hiding this comment.
We have the execution rules listed above in the docstring. To repeat here:
"""Execute tasks in group.
The following execution rules are enforced:
- The context stops executing all tasks if at least one task raises an Exception or the context is cancelled.
- The context re-raises Exceptions to the caller.
- The context re-raises CancelledErrors to the caller only if the context itself was cancelled.
"""
pgrayy
commented
Dec 17, 2025
| await asyncio.gather(*self._tasks) | ||
| pending_tasks = self._tasks | ||
| while pending_tasks: | ||
| done_tasks, pending_tasks = await asyncio.wait(pending_tasks, return_when=asyncio.FIRST_EXCEPTION) |
Member
Author
There was a problem hiding this comment.
Here we reassign pending_tasks which led mypy to complain about set[Task] vs list[Task] and thus why I switched self._tasks to set[Task].
pgrayy
force-pushed
the
bidi-async-3.11
branch
from
16f8271 to
a3b4074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing another Python 3.11+ feature from bidi. Specifically, removing the asyncio
task.cancellingcall. This call was used in determining how to propagateasyncio.CancelledErrors in our_TaskGroupimplementation.Note, this PR is part of a larger effort to add Python 3.10 and 3.11 support to
bidi. The final PR for this work is currently in draft here.Related Issues
#1299
Documentation PR
N/A
Type of Change
Other (please describe): Compatibility update.
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run preparehatch run bidi:prepare: Relying on both existing and new unit testshatch run bidi-test:test tests_integ/bidiChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.