Add requestId logging to BedrockModel #1358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add INFO level logging for Bedrock converse and converse_stream requestIds
- Use safe dictionary access for ResponseMetadata and RequestId
- Log format: 'Bedrock converse[_stream] requestId: {request_id}'
- Implements bedrock-request-id-logging spec requirements
sanjanasekar
requested a deployment
to
manual-approval
GitHub Actions
Waiting
dbschmigelski
requested changes
Dec 19, 2025
| if streaming: | ||
| response = self.client.converse_stream(**request) | ||
| request_id = response.get('ResponseMetadata', {}).get('RequestId') | ||
| logger.info(f"Bedrock converse_stream requestId: {request_id}") |
Member
There was a problem hiding this comment.
Hi, thanks for this.
If we are going to do this we should also make sure we are logging on exceptions, as that is generally when people want to inspect the request ids anyway.
I am also a bit curious about the need for info here, for exceptional cases I would understand info, but for happy path curious if debug is acceptable for your needs? More so probing at this point than recommending a change.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements bedrock-request-id-logging spec requirements
Changes Made
src/strands/models/bedrock.pyto add requestId logging in both streaming and non-streaming pathsself.client.converse_stream(**request)call (line ~1015)self.client.converse(**request)call (line ~1050)response.get('ResponseMetadata', {}).get('RequestId')Testing
Closes: bedrock-request-id-logging spec