(Fixes #75) Create temporary directory for dumping SMT files #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shigoel
changed the title
shigoel
changed the title
joehendrix
reviewed
Jan 16, 2026
| | .error err => | ||
| .error f!"❌ Type checking error.\n{format err}" | ||
| | .ok pEs => | ||
| let tempDir ← IO.toEIO (fun e => f!"{e}") IO.FS.createTempDir |
Contributor
There was a problem hiding this comment.
I think you want to use IO.FS.withTempDir or try/finally to remove the directory after running the verifier.
If this is intended to just write out the files for later verification, then I think it should take the directory as an argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#75
Description of changes:
Create a temporary directory for each
verifycall and suffix the SMT file names with a counter. Also add a new verbose modedebug, which is a level more than the previousdefaultand also prints the generated SMT file name.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.