Skip to content

History-query comments and minor refactor #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
quantumagi wants to merge 2 commits into
base: release/1.6.0.0
Choose a base branch
from
Open

History-query comments and minor refactor #1019

quantumagi wants to merge 2 commits into from

Conversation

@quantumagi
Copy link
Contributor

@quantumagi quantumagi commented Jul 11, 2022 •
edited
Loading

The PR has three minor improvements:

  • Add comments to history query
  • A subtle and less than obvious fix to avoid potential join expansion of staking rows.
  • Improved code robustness. Nulling of the wallet block locator field will trigger a re-sync instead of an error.

@quantumagi quantumagi requested review from fassadlr and zeptin July 11, 2022 11:01
@quantumagi quantumagi removed the request for review from zeptin July 11, 2022 11:36
@quantumagi quantumagi changed the base branch from master to release/1.4.0.0 July 13, 2022 05:43
@quantumagi quantumagi changed the title History query comments and minor refactor History-query comments and minor refactor Jul 20, 2022
@quantumagi quantumagi requested a review from zeptin July 28, 2022 08:42
@fassadlr fassadlr changed the base branch from release/1.4.0.0 to release/1.5.0.0 October 21, 2022 12:45
@fassadlr fassadlr added 1.6.0.0 and removed 1.4.0.0 labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fassadlr fassadlr Awaiting requested review from fassadlr

@zeptin zeptin Awaiting requested review from zeptin

Assignees

No one assigned

Labels

1.6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quantumagi @fassadlr