Fix empty strings for key=value pairs #277
Merged
+277
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Heffner <mikeh@fesnel.com>
Signed-off-by: Mike Heffner <mikeh@fesnel.com>
Contributor
Author
|
I'm going to merge at the moment because I discovered a large breaking change introduced in #262. At the moment we don't actually process the resource attributes at all unless we build with pyo3. I thought I was going crazy testing this and not seeing anything. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no way to pass an empty string for our key=value pair parameters. This meant it was difficult to configure cloudformation templates when a user may leave a field empty. Also, setting to empty could be used to "unset" a previous value.
Eg, this didn't work:
There doesn't seem to be a good way to do this cleanly with clap, so this PR converts these options to strings that we parse later. One upside, the clap and serde parsing (for multiple exporters) is now the same.
Completes: STR-3668, STR-3670