-
Notifications
You must be signed in to change notification settings - Fork 648
Docs: clarify picklable requirement for st.cache_resource #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
S-PANDIYAN
wants to merge
2
commits into
streamlit:main
Choose a base branch
from
S-PANDIYAN:Docs-clarify-picklable-requirement-for-st.cache_resource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems OK to me, it might be good to go into a bit more detail on the reason for the implementation. For example,
I am wondering whether we should change the actual error. Do you have any suggestions @sfc-gh-dmatthews
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might go with a little less detail in this case. I updated the docstrings for both
st.cache_dataandst.cache_resource:@sfc-gh-lwilby From your discussions, it sounds like it's only the fallback method that requires the object to be pickable, so I went with that as the point to highlight. "We hash most things just fine, but if that fails, the object must be pickleable." It didn't sound like pickable was actually a requirement...until everything else failed. If I've understood correctly, I would specifically catch that error when
__reduce__is used to say that the object is being hashed by a fallback method that requires the item be pickleable. I see thathashing.pyhas a lot of TODO items around creating more, specific warnings, so I can chat with you to figure something out.