This repository was archived by the owner on Feb 2, 2022. It is now read-only.
update contracts for ETH-197, setting them up correctly #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ETH-197 Make ENS-ckeck via chainlink automatic on stream creation.
when creating a stream with an ENSname, the oracle-lookup on mainchain should be done automatically and then the stream be created by the chainlink callback call. |
jtakalai
reviewed
Jan 10, 2022
There was a problem hiding this comment.
I can't see where the smart contract changes are, but if this works, it's good :)
EDIT: streamr-dev/network-contracts#109 apparently
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.