Use safe-buffer package #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ob-stripe
force-pushed
the
ob-use-safe-buffer
branch
from
0de18dd to
483cce9
Compare
Contributor
Author
|
Done! Tests are passing, so it should be safe to merge this. |
Contributor
|
LGTM. |
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
Use safe-buffer package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
ESLint recommends using the
safe-bufferpackage for Node <= 4.5, and it also lets us get rid of some code that we added to manually handle this (cf. #365).Let's wait until #387 is merged and this PR is rebased to make sure everything's still working as expected!