CHG: Replace fatal MPI_Abort with Warning in GetHistoryFieldValue #2664
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently,
GetHistoryFieldValueinCOutput.hpptriggers a fatalSU2_MPI::Error(causing anMPI_Abort) if a requested history field is missing. This behavior is overly aggressive for high-level interfaces (like the Python wrapper) or coupled simulations where a field might be temporarily unavailable or optional.Solution:
Replaced the fatal error with a warning message (
std::cout) and a default return value of0.0. This ensures the simulation continues running while alerting the user.Changes:
COutput.hpp: ReplacedSU2_MPI::Errorwith a warning print and safe return inGetHistoryFieldValue.