refactor: extract side-effect abstractions for testability and improve coverage #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sudokoi
commented
Nov 27, 2025
sudokoi
commented
- feat(tests): add more tests to improve coverage
- refactor: extract side-effect abstractions for testability and improve coverage
…e coverage - Add `app_deps.rs` module with injectable trait interfaces (GitHubApi, PromptInterface, RateLimiterInterface) - Implement factory pattern (GitHubApiFactory) for dependency injection - Refactor `App::run()` to delegate to `App::run_with_deps()` with injected dependencies - Add `async-trait` dependency for async trait method support - Replace direct function calls with trait method calls in business logic - Add `tests/app_run_with_deps_tests.rs` with mock implementations for integration testing - Improve overall coverage from 56.85% to 66.18% (+9.33%), with `src/app.rs` reaching 48% (+38.07%) Changes enable: - Testable main logic via dependency injection (MockGitHubApi, MockPrompt, MockRateLimiter) - Separation of side effects from pure business logic - Future addition of error path tests and CI coverage gates
sudokoi
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 57.69% 62.42% +4.73%
==========================================
Files 10 11 +1
Lines 728 857 +129
==========================================
+ Hits 420 535 +115
- Misses 308 322 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.