Skip to content

Conversation

@sudokoi
Copy link
Owner

@sudokoi sudokoi commented Dec 9, 2025

  • Implement modal dialog overlay for adding and editing repositories
  • Add strict alphanumeric validation for repository owner and name fields
  • Update key bindings: use 'e' to edit and 'Enter' to save/select
  • Refactor manage_config to use InputState and remove obsolete prompt_repository_details
  • Merge src/paths_tests_extra.rs into tests/paths_test.rs for better test organization
  • Update README with "Interactive Configuration" guide and update CHANGELOG

- Implement modal dialog overlay for adding and editing repositories
- Add strict alphanumeric validation for repository owner and name fields
- Update key bindings: use 'e' to edit and 'Enter' to save/select
- Refactor [manage_config](cci:1://file:///d:/code/github-secrets/tests/config_command_test.rs:54:4-58:5) to use [InputState](cci:2://file:///d:/code/github-secrets/src/prompt.rs:969:0-977:1) and remove obsolete `prompt_repository_details`
- Merge [src/paths_tests_extra.rs](cci:7://file:///d:/code/github-secrets/src/paths_tests_extra.rs:0:0-0:0) into [tests/paths_test.rs](cci:7://file:///d:/code/github-secrets/tests/paths_test.rs:0:0-0:0) for better test organization
- Update README with "Interactive Configuration" guide and update CHANGELOG
@sudokoi sudokoi self-assigned this Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 22.25705% with 248 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.37%. Comparing base (1508f8e) to head (210042c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/prompt.rs 18.18% 225 Missing ⚠️
src/app.rs 56.52% 10 Missing ⚠️
src/app_deps.rs 0.00% 7 Missing ⚠️
src/main.rs 0.00% 4 Missing ⚠️
src/paths.rs 80.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1508f8e) and HEAD (210042c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1508f8e) HEAD (210042c)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
- Coverage   62.42%   51.37%   -11.06%     
===========================================
  Files          11       11               
  Lines         857     1164      +307     
===========================================
+ Hits          535      598       +63     
- Misses        322      566      +244     
Flag Coverage Δ
unittests 51.37% <22.25%> (-11.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sudokoi sudokoi merged commit b99d044 into main Dec 9, 2025
4 of 6 checks passed
@sudokoi sudokoi deleted the config-subcommand branch December 9, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants