Skip to content

fix(ga4): interchange DEVB_BUY_ME_A_COFFEE_LINK and DEVB_GITHUB_LINK #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunithvs merged 1 commit into from
Aug 5, 2025
Merged

fix(ga4): interchange DEVB_BUY_ME_A_COFFEE_LINK and DEVB_GITHUB_LINK #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions www/components/modal/support-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const SupportModal = ({ user }: { user: Profile | null }) => {

{/* Fuel Code Card */}
<div
onClick={() => openInNewTab(DEVB_GITHUB_LINK)}
onClick={() => openInNewTab(DEVB_BUY_ME_A_COFFEE_LINK)}
Copy link

@gemini-code-assist gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the link is now correct, this onClick handler is on a div element, which is not keyboard-accessible by default. This prevents users who rely on keyboard navigation from using this feature. To make this interactive card accessible, the parent div should either be a <button> element or have role="button" and tabIndex={0} attributes.

className="flex flex-col items-center p-5 text-center bg-[#ffde30] rounded-xl cursor-pointer transition-all duration-300 hover:scale-[1.03] hover:shadow-lg relative group overflow-hidden"
>
<div className="absolute top-2 right-2 opacity-0 group-hover:opacity-100 transition-opacity duration-300">
Expand All @@ -107,7 +107,7 @@ export const SupportModal = ({ user }: { user: Profile | null }) => {

{/* Star GitHub Card */}
<div
onClick={() => openInNewTab(DEVB_BUY_ME_A_COFFEE_LINK)}
onClick={() => openInNewTab(DEVB_GITHUB_LINK)}
Copy link

@gemini-code-assist gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the other card, this onClick handler is on a non-interactive div element, making it inaccessible to keyboard users. Please consider converting the parent div to a <button> or adding role="button" and tabIndex={0} for proper accessibility.

className="flex flex-col items-center p-5 text-center bg-[#fff8d8] rounded-xl cursor-pointer transition-all duration-300 hover:scale-[1.03] hover:shadow-lg relative group overflow-hidden"
>
<div className="absolute top-2 right-2 opacity-0 group-hover:opacity-100 transition-opacity duration-300">
Expand Down
Loading