feat: Add CI/CD with GitHub Actions #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a basic CI/CD pipeline using GitHub Actions. The workflow is defined in `.github/workflows/ci.yml` and it includes the following steps: - Triggers on push to `main` and pull requests to `main`. - Sets up a Python environment. - Installs Poetry and project dependencies. - Runs `ruff` to lint the code. - Runs a smoke test to ensure the Streamlit app can be started.
This commit updates the CI workflow to use the latest versions of the following GitHub Actions: - `actions/checkout` from v3 to v4 - `actions/setup-python` from v2 to v5 - `actions/cache` from v2 to v4 This resolves the issue with the deprecated `actions/cache@v2`.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a basic CI/CD pipeline using GitHub Actions to automate code quality checks and testing. The workflow ensures code quality through linting and verifies the Streamlit application can start successfully.
- Adds GitHub Actions workflow for continuous integration
- Implements code linting with ruff
- Includes smoke testing for Streamlit app startup
This commit incorporates feedback from the code review: - The smoke test now uses `timeout` for a more reliable execution. - The `--server.headless true` flag is added to the streamlit command for CI environments. - The `snok/install-poetry` action is pinned to a specific version (`v1.3.4`) for better reproducibility.
The `timeout` command exits with code 124 when the process is terminated. This was causing the smoke test step to fail. This commit updates the smoke test command to treat exit code 124 as a success, ensuring the CI pipeline doesn't fail when the timeout works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a basic CI/CD pipeline using GitHub Actions. The workflow is defined in
.github/workflows/ci.ymland it includes the following steps:mainand pull requests tomain.ruffto lint the code.