Skip to content

Conversation

@tanvipandhre
Copy link

Day12 - game-of-life, find-all-numbers-disappeared-in-an-array, min-max

@super30admin
Copy link
Owner

  • Strengths:

    • Good understanding of temporary state patterns (Problem1 and Problem3).
    • Efficient use of space and time in Problem1 and Problem3.
    • Clear and readable code with appropriate comments.
  • Areas for Improvement:

    • Problem2 has syntax errors and logical flaws. Ensure all variables are declared and loops are correctly implemented.
    • The README.md is well-documented but could benefit from more detailed explanations of the algorithms, especially for Problem2.
    • Consider adding more edge case handling in Problem1 (e.g., empty input).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants