Skip to content

Conversation

@tanvipandhre
Copy link

Day3- implement-queue-using-stacks, Design-hashmap

@super30admin
Copy link
Owner

Strengths:

  • The student has clearly understood the problem requirements and implemented both solutions correctly.
  • The use of helper methods (like find in MyHashMap) improves code readability and reusability.
  • The comments and README explanations are clear and concise.

Areas for Improvement:

  • In the MyQueue implementation, the peek() method could be optimized to avoid unnecessary transfers when the out stack is not empty.
  • The README could be more detailed about the time and space complexity of the solutions.
  • The MyHashMap implementation could benefit from a brief explanation of the hash function choice (why 10000).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants