Skip to content

Conversation

@financialvice
Copy link
Contributor

@financialvice financialvice commented Jan 21, 2026

  • Respect comments highlight config (incl. active) in layout-engine renderer and expose CSS var fallbacks
  • Add CSS var support for track-change highlights in layout-engine
  • Add overlay highlight config + CSS vars; sync active comment highlight updates; docs/types update

Tests:
pnpm --filter @superdoc/painter-dom test (fails in existing table/border-utils.test.ts, 2 failures)
pnpm --filter @superdoc/super-editor test
pnpm --filter superdoc test

Visual:

  • Dev app w/ layout engine ON; verified CSS var overrides for comment highlight, track-change highlight, and overlay highlight

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 264926d7c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +923 to +927
const isInternal = el.dataset.commentInternal === 'true';
const comments = commentIds.map((commentId) => ({
commentId,
internal: isInternal,
trackedChange: false,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve per-comment internal/external flags in refresh

The new refreshCommentHighlights rebuilds the comments array from data-comment-ids using a single isInternal flag derived from data-comment-internal, which is set to true if any comment on the span is internal. If a span has mixed internal/external comments (supported by storing multiple IDs), switching the active thread to an external comment will still be treated as internal during refresh and will apply internal highlight colors/overrides. This regression only shows up on active-thread updates because the initial paint uses the real comment metadata. Consider persisting per-comment internal state (e.g., encode with the IDs) or reusing the original run metadata so refresh can choose the correct color.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant