fix(layout-bridge): correct cell selection for tables with rowspan #1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two bugs in hitTestTableFragment that caused incorrect cell selection in tables with merged cells (rowspan): 1. Rowspan X offset: When clicking cells in rows affected by rowspan from above, the X coordinate calculation now accounts for the visual space occupied by the rowspanned cell using ableMeasure.columnWidths. 2. Grid vs array index: The function now returns the cell array index (colIndex) instead of the grid column index for ProseMirror selection, fixing "Target column not found in row" errors.
4 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bd2d0a751
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in hitTestTableFragment that caused incorrect cell selection in tables with merged cells (rowspan):
Rowspan X offset: When clicking cells in rows affected by rowspan from above, the X coordinate calculation now accounts for the visual space occupied by the rowspanned cell using ableMeasure.columnWidths.
Grid vs array index: The function now returns the cell array index (colIndex) instead of the grid column index for ProseMirror selection, fixing "Target column not found in row" errors.