fix: before paragraph spacing inside table cells #1842
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 525f52e584
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const spacingBefore = (paraBlock.attrs as { spacing?: { before?: number } } | undefined)?.spacing | ||
| ?.before; | ||
| if (typeof spacingBefore === 'number' && spacingBefore > 0) { | ||
| height += spacingBefore; | ||
| } |
There was a problem hiding this comment.
Here you add spacing.before into the paragraph height, but the per-line Y position in selectionToRects is still based on blockTopCursor without that spacing. That means when a table cell paragraph has positive spacing.before and the selection is within that paragraph, the highlight rects are drawn too high by the spacing amount (only subsequent blocks are shifted). Consider adding spacing.before to blockTopCursor (or the line offset) when the rendered range starts at line 0 so the selection rects match the new render position.
Useful? React with 👍 / 👎.
No description provided.