fix: structured content renders correct on hover and select #1843
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58e6c67445
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const resolved = this.#resolveStructuredContentBlockFromElement(doc, structuredContentLabel); | ||
| if (resolved) { | ||
| try { | ||
| const tr = editor.state.tr.setSelection(TextSelection.create(doc, resolved.start, resolved.end)); | ||
| editor.view?.dispatch(tr); |
There was a problem hiding this comment.
Clicking a structured-content block label uses TextSelection.create(doc, resolved.start, resolved.end), but those positions are at the start/end of a structuredContentBlock (a block node with content: 'block*'), so ProseMirror throws “Not a text selection” and the try/catch silently drops the selection. In practice, clicking the block SDT label becomes a no-op; use NodeSelection.create(doc, resolved.pos) or select inside a textblock child to make label clicks work for block SDTs.
Useful? React with 👍 / 👎.
| const showLabel = isStart && !sdtLabelsRendered.has(currentKey); | ||
| if (showLabel) { | ||
| sdtLabelsRendered.add(currentKey); | ||
| } |
There was a problem hiding this comment.
showLabel is suppressed once a key is in sdtLabelsRendered, but that set is only cleared in paint(). In virtualized mode, updateVirtualWindow mounts/unmounts pages without calling paint(), so after scrolling away and back, the start fragment’s label won’t render because the key is still in the set. This makes SDT labels disappear on virtual scroll; reset the set per virtual window rebuild or scope it to mounted pages.
Useful? React with 👍 / 👎.
In layout engine, fix the rendered styling for structured content:
Adds VRTs.