Skip to content

Fix value normalization and animation issues #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianrumac merged 2 commits into from
Jan 6, 2026
Merged

Fix value normalization and animation issues #341

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d5d091
Fix crash when drawer height is set to 100%
claude Jan 5, 2026
dcae7f4
Update comment to explain why ratio is clamped
claude Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions superwall/src/main/java/com/superwall/sdk/paywall/view/SuperwallPaywallActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,8 +520,9 @@ class SuperwallPaywallActivity : AppCompatActivity() {
val content = contentView as ViewGroup
val bottomSheetBehavior = BottomSheetBehavior.from(content.getChildAt(0))
if (!isModal) {
bottomSheetBehavior.halfExpandedRatio =
(if (height > 1.0) height / 100 else height).toFloat()
val normalizedHeight = (if (height > 1.0) height / 100 else height).toFloat()
// Clamp to (0, 1) since 0.0 = STATE_COLLAPSED and 1.0 = STATE_EXPANDED
bottomSheetBehavior.halfExpandedRatio = normalizedHeight.coerceIn(0.01f, 0.99f)
} else {
// If it's a Modal, we want it to cover only 95% of the screen when expanded
content.updateLayoutParams {
Expand Down
Loading