Content #9
Content #9
Conversation
|
@lukeware I'm glad that you brought up the workflow for the Bio-Page! I would have also preferred to have worked from a pull request, however project structure and the time we had for our sprint made me opt for working on my own branch. I decided not to work on the bio-branch to avoid interrupting your work, and thought it would be redundant to make second bio branch for my code, so I opted to work on my Content branch to keep my work organized and unobtrusive. |
|
|
||
| <p>She became a poet and writer after a series of occupations as a young adult, including fry cook, sex worker, nightclub dancer and performer, cast member of the opera Porgy and Bess, coordinator for the Southern Christian Leadership Conference, and journalist in Egypt and Ghana during the decolonization of Africa. She was an actor, writer, director, and producer of plays, movies, and public television programs. In 1982, she earned the first lifetime Reynolds Professorship of American Studies at Wake Forest University in Winston-Salem, North Carolina. She was active in the Civil Rights movement and worked with Martin Luther King Jr. and Malcolm X. Beginning in the 1990s, she made around 80 appearances a year on the lecture circuit, something she continued into her eighties. In 1993, Angelou recited her poem "On the Pulse of Morning" (1993) at President Bill Clinton's inauguration, making her the first poet to make an inaugural recitation since Robert Frost at President John F. Kennedy's inauguration in 1961.</p> | ||
|
|
||
| <div class="work"> |
| <p class="text-muted"> | ||
| Maya Angelou, “Caged Bird” from Shaker, Why Don't You Sing? Copyright © 1983 by Maya Angelou. | ||
| </p> | ||
| <button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button> |
There was a problem hiding this comment.
Between modal and share buttons we would add a "listen" button and link to each corresponding poem media file in the media folder. This is me testing code line comments! Pretty cool. Would look like this: <a class="btn btn-primary" href="/media/Maya-Angelou-Caged-Bird.mp3">Listen <span class="glyphicon glyphicon-music"></span>
There was a problem hiding this comment.
Great idea, Luke. I think that's an excellent place for the 'listen' button.
| <!-- Modal --> | ||
| <button class="btn btn-primary" data-toggle="modal" data-target="#poem1">Read More <span class="glyphicon glyphicon-chevron-right"></span></button> | ||
|
|
||
| <div class="modal fade" id="poem1" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> |
There was a problem hiding this comment.
Kira, I think it's great what you're doing with the modals in the archive. Nice job!
lukeware
left a comment
lukeware
left a comment
There was a problem hiding this comment.
Trying out a general comment! Looks good. We are truly the best. This poetry page is going to sell like hotcakes.
| <body> | ||
|
|
||
| <!-- Navigation --> | ||
| <nav class="navbar navbar-inverse navbar-fixed-top" role="navigation"> |
There was a problem hiding this comment.
Just learned that when using the <nav> element it's redundant to also designate the "role="navigation" and should be avoided. Not a big deal but since we are doing code review thought I'd chime in. Bleep bloop!
meganmotis
left a comment
meganmotis
left a comment
There was a problem hiding this comment.
Kira, really nice job on the archive. I also really appreciate the added content to the bio page, and how that will also play into the Amazon integration in future sprints (if such there be).
|
|
||
| <!-- First Poem --> | ||
| <h2>Caged Bird</h2> | ||
| <p class="text-muted"> |
There was a problem hiding this comment.
Kira, I love your use of the class 'text-muted' - I think it adds a super classy touch.
| <p class="text-muted"> | ||
| by Maya Angelou | ||
| </p> | ||
| <p><span class="glyphicon glyphicon-book"></span> Published: 1983</p> |
There was a problem hiding this comment.
Similarly to my comment with Luke's use of the glyphicons, I like the use of the glyphicon-book in the archives. I think these are great little touches that add significantly to the usability.
| </p> | ||
| <p><span class="glyphicon glyphicon-book"></span> Published: 1983</p> | ||
| <hr> | ||
| <img class="img-responsive" src="http://placehold.it/900x300" alt=""> |
There was a problem hiding this comment.
Kira, I appreciate the image placeholders for the book covers - I think this would set us up well for future sprints (if such there be) when we'd get around to incorporating the Amazon integration elements into the site.
| <!-- Modal --> | ||
| <button class="btn btn-primary" data-toggle="modal" data-target="#poem2">Read More <span class="glyphicon glyphicon-chevron-right"></span></button> | ||
|
|
||
| <div class="modal fade" id="poem2" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> |
There was a problem hiding this comment.
Kira, I really feel like I've learned a lot from reviewing your code on the modals. This is a very cool piece of functionality for our archive, and I love the way the modal fade looks. Excellent job with this.
| Maya Angelou, “On the Pulse of Morning” (excerpt) from On the Pulse of Morning. Copyright © 1993 by Maya Angelou. | ||
| </p> | ||
| <button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button> | ||
| <button type="button" class="btn btn-primary">Share</button> |
There was a problem hiding this comment.
Again, I appreciate incorporating a Share button as a place holder for work in future sprints to incorporate the social media functionality.
Hey everyone! This branch includes work for the Poetry Archive and Bio Page.
Issue #3 Poetry Archive
Here I added 9 notable Maya Angelou poems to the archive. On the archive page the user is able to preview each poem by seeing the title, publishing date, and a 2-3 line preview of the poem. The user can then click into a modal view and read the full poem. For times sake there are a few requirements that still need to be met like adding search capabilities, and images.
Issue #4 Bio
On the bio page I mainly added some supplementary details to the make biography content added by Luke. I added a list of her literature to the page so users could learn more, and help meet the amazon integration requirements.