Img save delete #18
Img save delete #18
Conversation
lukevpoel
requested review from
a user,
KMcWeeney22,
hlkessner,
jackiebuttice,
kevinsheen and
lariosw
| margin-top: 10px; | ||
| margin-left: 5%; | ||
| margin-right: 5%; | ||
| } |
There was a problem hiding this comment.
How about a border radius on the buttons to soften it? border-radius: 30px;
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Image -favorite and delete area looks good on the page and nice consistency on the main images.
There was a problem hiding this comment.
I like your additions to this branch and image adjustments in the css, we could potentially include a border radius down the road, or attempt to soften edges as I do like Isa's idea to do that. The styles look good and work for the chosen artist images like Poe, Thompson, and Dickens. The index.html additions look good as well. Having a favorite images section will enhance the experience for the users. I like the places for the Favorite button and the Delete button. Obviously this will work when profiles are working but is a key feature when using those profiles. Seems in line with the user interaction for PDG Poetry. Good PR and I approve for merging this pull request into the master branch! -Kevin
| </div> | ||
| </div> | ||
|
|
||
| <div class="col-xs-12 fave-images"> |
There was a problem hiding this comment.
The favorite images section looks good, and the addition of the "favorite" and "Delete" buttons are a nice touch.
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This styling for the images looks good, and maybe down the road we can that border radius.
This branch is intended to solve 2 very similar issues. It still needs styling, to be linked to each saved image, and additional JS for complete functionality. This should be merged into a base with working profiles.
#13
#14