Task profile friends #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lariosw
requested review from
a user,
KMcWeeney22,
hlkessner,
kevinsheen and
lukevpoel
KMcWeeney22
reviewed
Feb 19, 2017
| <div class="each-friend friend-2"> Josi Doe</div> | ||
| <img src="images/brunettelady.jpg"> | ||
| <div class="each-friend friend-3"> Jim Doe</div> | ||
| <img src="images/brunetteman.jpeg"> |
Collaborator
There was a problem hiding this comment.
Maybe there could be a button added after each picture to view each friends profile.
Collaborator
There was a problem hiding this comment.
I agree with this. Even if we just change the name or image to links to the friend's profile
lukevpoel
reviewed
Feb 20, 2017
index.html
Outdated
| <input type="password" placeholder="Password" class="form-control"> | ||
| </div> | ||
| <button type="submit" class="btn btn-success">Sign in</button> | ||
| <button type="create" class="btn btn-create">Create Account</button> |
Collaborator
There was a problem hiding this comment.
Is this for us to remove the ability to create a new account, or to simulate already being signed in?
lukevpoel
reviewed
Feb 20, 2017
Collaborator
lukevpoel
left a comment
lukevpoel
left a comment
There was a problem hiding this comment.
Looks good. I agree with Kyle's assessment that each friend should have some kind of link back to their profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #10 updated the ability to add friends list and display number of friends to profile with photos. Still need to make photos of friends that display randomized.