Skip to content

Conversation

@reitermarkus
Copy link
Contributor

@reitermarkus reitermarkus commented Mar 27, 2022

The name into_array feels a bit out of place. Most methods of this type in the standard library are called to_bytes taking &self. The IpAddr types call it octets however.

Given there is already as_bytes, maybe calling it to_bytes is the better option.

@reitermarkus reitermarkus force-pushed the octets branch 2 times, most recently from d96db40 to afa091c Compare March 27, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant