feat: use rolldown optimizer plugin for remote functions #15024
+42
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 243eb27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Dec 3, 2025
| } | ||
| }; | ||
| if (is_rolldown && new_config.optimizeDeps) { | ||
| delete new_config.optimizeDeps.esbuildOptions; // vite 8 logs a warning when esbuildOptions is used |
Member
There was a problem hiding this comment.
rather than deleting it, we should probably only add it if !is_rolldown
Member
Author
There was a problem hiding this comment.
refactored to nested conditionals for adding the plugins only when they are needed
Member
Author
|
tried bumping vite, vitest and playwright to latest versions and run kit tests but that requires some changes that are out of scope for this PR, recommending to keep it draft until deps are more up2date in this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vite 8 beta was released today and it logs a warning when esbuildOptions is used for the optimizer. vite-plugin-svelte already uses rolldown optimizer.
needs testing and maybe a refactor to move the esbuild and rolldown plugins closer together. Right now its not really great for readability but its temporal because we can drop the esbuild plugin altogether when vite8 is lowest supported version.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits