Skip to content

Conversation

@mu-nreal
Copy link
Collaborator

StdAfx.cpp -> MUMain/StdAfx.cpp
stdafx.h -> MUMain/stdafx.h
Winmain.cpp -> MUMain/Winmain.cpp
Winmain.h -> MUMain/Winmain.h
resource.h -> MUMain/Resources/Windows/resource.h
resource.rc -> MUMain/Resources/Windows/resource.rc
resource.aps -> MUMain/Resources/Windows/resource.aps
icon1.ico -> MUMain/Resources/Windows/icon1.ico
icon2.ico -> MUMain/Resources/Windows/icon2.ico
Global Release/resource.res -> MUMain/Resources/Windows/Global Release/resource.res

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mu-nreal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring initiative to enhance the project's modularity and maintainability. It involves relocating core application bootstrap files and Windows resources into a more structured directory hierarchy under MUMain/. This change necessitated widespread updates to include paths across the codebase and modifications to project build configurations, ensuring a cleaner and more organized project structure.

Highlights

  • Core Bootstrap and Windows Resources Modularization: Key bootstrap files (stdafx.h, stdafx.cpp, Winmain.h, Winmain.cpp) and Windows-specific resources (resource.h, resource.rc, icon1.ico, icon2.ico, resource.aps, Global Release/resource.res) have been moved into dedicated MUMain/ and MUMain/Resources/Windows/ subdirectories.
  • Extensive Include Path Updates: Numerous source files and project configuration files (CMakeLists.txt, Main.vcxproj, Main.vcxproj.filters) have been updated to reflect the new, organized include paths for the relocated files.
  • Minor Code Refinements: Small adjustments were made, including explicit type casting for window dimensions in Winmain.cpp and float literal corrections in stdafx.h, alongside minor comment updates in several UI-related files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on restructuring the project's file organization by relocating common header files, resource files, and source files into a new MUMain subdirectory. Specifically, stdafx.h, resource.h, Winmain.h, and associated resource files like icon1.ico, icon2.ico, and resource.rc have been moved. The changes involve updating include paths across numerous .cpp files, modifying XSLT templates to reflect the new header locations, and updating CMakeLists.txt, Main.vcxproj, and Main.vcxproj.filters to correctly reference the relocated files. Additionally, minor code adjustments include adding static_cast<LONG> for WindowWidth and WindowHeight in Winmain.cpp, changing GLvoid to void for KillGLWindow in Winmain.h, and adding explicit float suffixes (.0f) to g_fScreenRate_x and g_fScreenRate_y in stdafx.h. The original stdafx.cpp was removed, and a new one was created in the MUMain directory. There were no specific review comments provided for these changes.

@mu-nreal mu-nreal marked this pull request as draft December 17, 2025 13:51
@mu-nreal mu-nreal marked this pull request as ready for review December 17, 2025 23:23
@mu-nreal mu-nreal marked this pull request as draft December 19, 2025 00:47
@mu-nreal mu-nreal marked this pull request as ready for review December 19, 2025 08:39
@sven-n sven-n marked this pull request as draft January 4, 2026 17:54
@sven-n
Copy link
Owner

sven-n commented Jan 4, 2026

Please resolve the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants