-
Notifications
You must be signed in to change notification settings - Fork 161
Modularize MUMain (bootstrap + Win resources) #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mu-nreal
commented
Dec 16, 2025
…cit suffix in StdAfx files
Summary of ChangesHello @mu-nreal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring initiative to enhance the project's modularity and maintainability. It involves relocating core application bootstrap files and Windows resources into a more structured directory hierarchy under Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on restructuring the project's file organization by relocating common header files, resource files, and source files into a new MUMain subdirectory. Specifically, stdafx.h, resource.h, Winmain.h, and associated resource files like icon1.ico, icon2.ico, and resource.rc have been moved. The changes involve updating include paths across numerous .cpp files, modifying XSLT templates to reflect the new header locations, and updating CMakeLists.txt, Main.vcxproj, and Main.vcxproj.filters to correctly reference the relocated files. Additionally, minor code adjustments include adding static_cast<LONG> for WindowWidth and WindowHeight in Winmain.cpp, changing GLvoid to void for KillGLWindow in Winmain.h, and adding explicit float suffixes (.0f) to g_fScreenRate_x and g_fScreenRate_y in stdafx.h. The original stdafx.cpp was removed, and a new one was created in the MUMain directory. There were no specific review comments provided for these changes.
…UMain subdirectory structure
…ture in Random.cpp
|
Please resolve the conflicts |