-
Notifications
You must be signed in to change notification settings - Fork 161
Fix 264 and refactor #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix 264 and refactor #271
Conversation
…sting library dependencies, and optimizing performance-critical file configurations.
Summary of ChangesHello @Mosch0512, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issue #264 by performing a comprehensive refactoring and cleanup of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly refactors the Main.vcxproj project file, leading to a much cleaner and more maintainable build configuration. Key improvements include the removal of hardcoded absolute paths for dependencies like Boost and DirectX SDK, the consolidation of duplicated compiler settings, and the consistent use of standard MSBuild properties like $(SolutionDir) and $(IntDir). These are excellent changes that will improve build portability and reduce configuration complexity.
I have one concern regarding the change in linking shlwapi.lib. It has been moved to be linked only in Release builds, which means it's no longer linked for Win32 Debug builds. This could potentially cause linker errors if any code in that configuration depends on it. Please see my specific comment for details.
| </ClCompile> | ||
| <Link> | ||
| <AdditionalDependencies>shlwapi.lib;crypt32.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
| <AdditionalDependencies>crypt32.lib;%(AdditionalDependencies)</AdditionalDependencies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shlwapi.lib dependency has been moved from this Win32 platform definition group to a Global Release configuration group. This means it will no longer be linked in Win32 Debug builds. Please confirm that no functions from shlwapi.dll are used in debug configurations for the Win32 platform, as this change could lead to linker errors.
closes #264