Fixed newlines in log message being stripped, and multiple log entries on the same connection #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added dummy missing icons. Created from Syncfusion metro studio icons. Added missing app.config for TestNlog. Changed Log4Net to be gotten from Nuget.
Saved project in visual Studio 2015.
Replace \r\n or \n with \line
Will create a log entry with any exception thrown. Would like to be able to capture the raw log and return that on a parser exception.
Reinstalled test nuget packages.
…efits. 1st is it will allow us to get the text of the record when the parsing fails. 2nd we no longer have to wait until the stream is closed to receive the last log message. Added another test to send some really mangled XML.
Fixed Log4J parse bug.
…o tokenizer # Conflicts: # src/Log2Console/Log2Console.csproj
…tting an error about not being able to check it out.
Made a cmd file to zip install to a single exe.
Added context to serilog test.
MarcWeintraub
left a comment
MarcWeintraub
left a comment
There was a problem hiding this comment.
I tried the new line changes and THANK YOU for fixing this! Hope everyone can enjoy it soon too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://log2console.codeplex.com/workitem/17661
Multiple log entries send over same connection lost.
Can be demonstrated by running the included TestNlog. I did make some modifications to the test program, but even before the modifications only the 1st log message sent on a connection was processed.
http://log2console.codeplex.com/workitem/17658
NewLine in Log Message Stripped
Never looked at the source previously, and maybe I'm crazy, but I used to be able to send log messages with multiple lines. Fixed by replacing newline in log message with \ling for the rtf. Verified with the copy button also. This too can be demonstrated with the TestNLog program.
Moved Test Programs into a tests directory
This could probably be moved to a separate pull request, but the impact seemed low, and I'm not sure if this project is being actively developed.