-
Notifications
You must be signed in to change notification settings - Fork 88
Add command to create a Swift DocC documentation catalog #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amanthatdoescares
wants to merge
6
commits into
swiftlang:main
Choose a base branch
from
amanthatdoescares:add-docc-command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
43e2518
Add command to create Swift DocC documentation catalog
amanthatdoescares 81461d5
Add command to create Swift DocC documentation catalog
amanthatdoescares 6291552
restoring package-lock-json
amanthatdoescares 3277a02
Use async filesystem APIs, Included Copyright Headers, changed the va…
amanthatdoescares a528243
Validate Docc Catalog exisitance inside input
amanthatdoescares 62a4225
Ask user to select the workspace folder and validate docc name inline
amanthatdoescares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the VS Code Swift open source project | ||
| // | ||
| // Copyright (c) 2021-2024 the VS Code Swift project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of VS Code Swift project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| import * as fsSync from "fs"; | ||
| import * as fs from "fs/promises"; | ||
| import * as path from "path"; | ||
| import * as vscode from "vscode"; | ||
|
|
||
| export async function createDocumentationCatalog(): Promise<void> { | ||
| const folders = vscode.workspace.workspaceFolders; | ||
| if (!folders || folders.length === 0) { | ||
| void vscode.window.showErrorMessage( | ||
| "Creating a documentation catalog requires that a folder or workspace be opened" | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| let folder: vscode.WorkspaceFolder | undefined; | ||
|
|
||
| if (folders.length === 1) { | ||
| folder = folders[0]; | ||
| } else { | ||
| folder = await vscode.window.showWorkspaceFolderPick({ | ||
| placeHolder: "Select a workspace folder to create the DocC catalog in", | ||
| }); | ||
| } | ||
|
|
||
| if (!folder) { | ||
| return; | ||
| } | ||
|
|
||
| const rootPath = folder.uri.fsPath; | ||
|
|
||
| const moduleName = await vscode.window.showInputBox({ | ||
| prompt: "Enter Swift module name", | ||
| placeHolder: "MyModule", | ||
| validateInput: value => { | ||
| if (value.trim().length === 0) { | ||
| return "Module name cannot be empty"; | ||
| } | ||
|
|
||
| const doccDir = path.join(rootPath, `${value}.docc`); | ||
| if (fsSync.existsSync(doccDir)) { | ||
| return `Documentation catalog "${value}.docc" already exists`; | ||
| } | ||
|
|
||
| return undefined; | ||
| }, | ||
| }); | ||
|
|
||
| if (!moduleName) { | ||
| return; // user cancelled | ||
| } | ||
|
|
||
| const doccDir = path.join(rootPath, `${moduleName}.docc`); | ||
| const markdownFile = path.join(doccDir, `${moduleName}.md`); | ||
|
|
||
| await fs.mkdir(doccDir, { recursive: true }); | ||
| await fs.writeFile(markdownFile, `# ${moduleName}\n`, "utf8"); | ||
|
|
||
| void vscode.window.showInformationMessage( | ||
| `Created DocC documentation catalog: ${moduleName}.docc` | ||
| ); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: We can't assume that the user will only place a catalog at the root of the workspace. Documentation catalogs can be located anywhere in the project structure. However, they are most commonly placed within targets from the
Package.swiftto provide documentation for them. I would show a quick pick with the available targets and an option at the end for creating a standalone documentation catalog.