Implemented FtpSource based on FluentFtp library #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented FtpSource based on FluentFtp library
Owner
|
Great, thanks! Any reason you are using FluentFTP and not the CLR's classes ? We would like to keep this library without dependencies See https://msdn.microsoft.com/en-us/library/system.net.ftpwebrequest.aspx |
Author
|
Ohh, you're right, I've been thinking about it, but just for time economy decided to use FluentFTP. I will rewrite it to CLR :) |
PurpleGray
force-pushed
the
ftp_source
branch
2 times, most recently
from
150fdb3 to
acd721f
Compare
Author
|
Ok, moved from FluentFTP to CLR |
Additional dependency FluentFTP replaced by CLR's FTP client implementation
Owner
|
Thanks, looks good! Any chance you can add tests for this new Source class? |
Author
|
Yep, I'll do it in this week |
Author
|
Hm, but how can I test ftp source? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, in my project I've been using your library, but my requirement was to update from ftp. So I've added new type of source, so created this pull request. May be it can be useful for someone.