Skip to content

Fix/fallback expired ln to onchain update #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piotr-iohk wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −35
Open

Fix/fallback expired ln to onchain update #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9422b48
Sending to unified invoice w/ expired invoice on iOS after fix
piotr-iohk Jan 12, 2026
2fcef8d
formatting
piotr-iohk Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/helpers/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ export function getRnAppPath(): string {
const fallback = path.join(__dirname, '..', '..', 'aut', 'bitkit_rn_regtest.apk');
const appPath = process.env.RN_APK_PATH ?? fallback;
if (!fs.existsSync(appPath)) {
throw new Error(
`RN APK not found at: ${appPath}. Set RN_APK_PATH or place it at ${fallback}`
);
throw new Error(`RN APK not found at: ${appPath}. Set RN_APK_PATH or place it at ${fallback}`);
}
return appPath;
}
Expand Down
11 changes: 9 additions & 2 deletions test/specs/migration.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import { elementById, restoreWallet, sleep, tap, typeText, waitForSetupWalletScreenFinish } from '../helpers/actions';
import {
elementById,
restoreWallet,
sleep,
tap,
typeText,
waitForSetupWalletScreenFinish,
} from '../helpers/actions';
import { ciIt } from '../helpers/suite';
import { getNativeAppPath, getRnAppPath, reinstallAppFromPath } from '../helpers/setup';

Expand Down Expand Up @@ -41,7 +48,7 @@ async function restoreLegacyRnWallet(seed: string) {
await waitForSetupWalletScreenFinish();

const getStarted = await elementById('GetStartedButton');
await getStarted.waitForDisplayed( { timeout: 120000 });
await getStarted.waitForDisplayed({ timeout: 120000 });
await tap('GetStartedButton');
await sleep(1000);
}
54 changes: 24 additions & 30 deletions test/specs/send.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,37 +328,31 @@ describe('@send - Send', () => {

// send to unified invoice w/ expired invoice
let amtAfterUnified3: string;
if (driver.isAndroid) {
console.info('Sending to unified invoice w/ expired invoice...');
const unified3 =
'bitcoin:bcrt1qaytrqsrgg75rtxrtr7ur6k75la8p3v95mey48z?lightning=LNBCRT1PN33T20DQQNP4QTNTQ4D2DHDYQ420HAUQF5TS7X32TNW9WGYEPQZQ6R9G69QPHW4RXPP5QU7UYXJYJA9PJV7H6JPEYEFFNZ98N686JDEAAK8AUD5AGC5X70HQSP54V5LEFATCQDEU8TLKAF6MDK3ZLU6MWUA52J4JEMD5XA85KGKMTTQ9QYYSGQCQPCXQRRSSRZJQWU6G4HMGH26EXXQYPQD8XHVWLARA66PL53V7S9CV2EE808UGDRN4APYQQQQQQQGRCQQQQLGQQQQQQGQ2QX7F74RT5SQE0KEYCU47LYMSVY2LM4QA4KLR65PPSY55M0H4VR8AN7WVM9EFVSPYJ5R8EFGVXTGVATAGFTC372VRJ3HEPSEELFZ7FQFCQ9XDU9X';
console.info({ unified3 });

// const ln =
// 'LNBCRT1PN33T20DQQNP4QTNTQ4D2DHDYQ420HAUQF5TS7X32TNW9WGYEPQZQ6R9G69QPHW4RXPP5QU7UYXJYJA9PJV7H6JPEYEFFNZ98N686JDEAAK8AUD5AGC5X70HQSP54V5LEFATCQDEU8TLKAF6MDK3ZLU6MWUA52J4JEMD5XA85KGKMTTQ9QYYSGQCQPCXQRRSSRZJQWU6G4HMGH26EXXQYPQD8XHVWLARA66PL53V7S9CV2EE808UGDRN4APYQQQQQQQGRCQQQQLGQQQQQQGQ2QX7F74RT5SQE0KEYCU47LYMSVY2LM4QA4KLR65PPSY55M0H4VR8AN7WVM9EFVSPYJ5R8EFGVXTGVATAGFTC372VRJ3HEPSEELFZ7FQFCQ9XDU9X';
// const dec = await lnd.decodePayReq({ payReq: ln });
// console.info(JSON.stringify(dec, null, 2));
console.info('Sending to unified invoice w/ expired invoice...');
const unified3 =
'bitcoin:bcrt1qaytrqsrgg75rtxrtr7ur6k75la8p3v95mey48z?lightning=LNBCRT1PN33T20DQQNP4QTNTQ4D2DHDYQ420HAUQF5TS7X32TNW9WGYEPQZQ6R9G69QPHW4RXPP5QU7UYXJYJA9PJV7H6JPEYEFFNZ98N686JDEAAK8AUD5AGC5X70HQSP54V5LEFATCQDEU8TLKAF6MDK3ZLU6MWUA52J4JEMD5XA85KGKMTTQ9QYYSGQCQPCXQRRSSRZJQWU6G4HMGH26EXXQYPQD8XHVWLARA66PL53V7S9CV2EE808UGDRN4APYQQQQQQQGRCQQQQLGQQQQQQGQ2QX7F74RT5SQE0KEYCU47LYMSVY2LM4QA4KLR65PPSY55M0H4VR8AN7WVM9EFVSPYJ5R8EFGVXTGVATAGFTC372VRJ3HEPSEELFZ7FQFCQ9XDU9X';
console.info({ unified3 });

// const ln =
// 'LNBCRT1PN33T20DQQNP4QTNTQ4D2DHDYQ420HAUQF5TS7X32TNW9WGYEPQZQ6R9G69QPHW4RXPP5QU7UYXJYJA9PJV7H6JPEYEFFNZ98N686JDEAAK8AUD5AGC5X70HQSP54V5LEFATCQDEU8TLKAF6MDK3ZLU6MWUA52J4JEMD5XA85KGKMTTQ9QYYSGQCQPCXQRRSSRZJQWU6G4HMGH26EXXQYPQD8XHVWLARA66PL53V7S9CV2EE808UGDRN4APYQQQQQQQGRCQQQQLGQQQQQQGQ2QX7F74RT5SQE0KEYCU47LYMSVY2LM4QA4KLR65PPSY55M0H4VR8AN7WVM9EFVSPYJ5R8EFGVXTGVATAGFTC372VRJ3HEPSEELFZ7FQFCQ9XDU9X';
// const dec = await lnd.decodePayReq({ payReq: ln });
// console.info(JSON.stringify(dec, null, 2));

await sleep(1000);
await enterAddress(unified3, { acceptCameraPermission: false });
await elementById('AssetButton-savings').waitForDisplayed();
await tap('N1');
await multiTap('N0', 4);
await tap('ContinueAmount');
await reviewAmt.waitForDisplayed();
await expect(reviewAmt).toHaveText('10 000');
await dragOnElement('GRAB', 'right', 0.95);
await elementById('SendSuccess').waitForDisplayed();
await tap('Close');
await expect(totalBalance).not.toHaveText(amtAfterUnified2);
amtAfterUnified3 = await totalBalance.getText();
console.info({ amtAfterUnified3 });
await expectTextWithin('ActivitySpending', '7 000');
} else {
// https://github.com/synonymdev/bitkit-ios/issues/300
console.info('Skipping sending to unified invoice w/ expired invoice on iOS due to /bitkit-ios/issues/300');
amtAfterUnified3 = amtAfterUnified2;
}
await sleep(1000);
await enterAddress(unified3, { acceptCameraPermission: false });
await elementById('AssetButton-savings').waitForDisplayed();
await tap('N1');
await multiTap('N0', 4);
await tap('ContinueAmount');
await reviewAmt.waitForDisplayed();
await expect(reviewAmt).toHaveText('10 000');
await dragOnElement('GRAB', 'right', 0.95);
await elementById('SendSuccess').waitForDisplayed();
await tap('Close');
await expect(totalBalance).not.toHaveText(amtAfterUnified2);
amtAfterUnified3 = await totalBalance.getText();
console.info({ amtAfterUnified3 });
await expectTextWithin('ActivitySpending', '7 000');

// send to unified invoice w/o amount (lightning)
console.info('Sending to unified invoice w/o amount (lightning)...');
Expand Down