refactor: simplify extension to avoid LDK node startup #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The notification service extension now follows a lightweight approach that avoids iOS memory (~24MB) and time (~30s) constraints by not starting the LDK node in the extension. Changes: - NotificationService now only decrypts payload and displays time-sensitive notifications with urgency messaging - Added IncomingPaymentInfo model to persist payment data between extension and main app via App Group UserDefaults - Main app now processes incoming payments when it becomes active, with priority handling for node startup and LSP peer connection - Notifications are auto-removed after payment expiry window (2 minutes) - AppViewModel clears pending payments when payment is received
ovitrif
force-pushed
the
feat/push-notif-wo-delivery
branch
from
4991f92 to
15f1a14
Compare
ovitrif
changed the title
ovitrif
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The notification service extension now follows a lightweight approach that avoids iOS memory (~24MB) and time (~30s) constraints by not starting ldk-node in the extension.
Changes:
NotificationServicenow only decrypts payload and displays time-sensitive notifications with urgency messagingIncomingPaymentInfomodel to persist payment data between extension and main app via App Group UserDefaultsAppViewModelclears pending payments when payment is receivedLinked Issues/Tasks
n/a
Screenshot / Video
n/a