fix: fallback expired Bolt 11 to on-chain on unified invoice #320
+34
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of expired Bolt 11 invoices in unified invoices by implementing a fallback to on-chain payment when the Lightning invoice has expired. It also addresses a navigation bug where the app would incorrectly navigate to the amount screen even when scanning an invalid Bolt 11 invoice without a valid on-chain address.
Changes:
- Added expiration checks for Lightning invoices in unified invoice handling with fallback to on-chain when expired
- Fixed navigation logic to prevent navigation when no valid invoice data exists
- Added expiration validation for standalone Lightning invoices
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Bitkit/ViewModels/AppViewModel.swift | Added expiration checks for Lightning invoices with on-chain fallback logic in unified invoice handling |
| Bitkit/Utilities/PaymentNavigationHelper.swift | Changed return type to optional and added validation to prevent navigation without valid invoice data |
| Bitkit/Views/Wallets/Send/SendEnterManuallyView.swift | Updated to handle optional navigation route from PaymentNavigationHelper |
| Bitkit/Views/Wallets/Send/SendConfirmationView.swift | Added expiration check before processing Lightning payments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues/Tasks
Fix #300
Screenshot / Video
uniffied-no-amount.mp4
unified-with-amount.mp4
ln-only.mp4